feat: SITES-26526 Import Assistant service phase 1 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apper for Firefall
…apper for Firefall - imports.assistant
…apper for Firefall - html input removal, tests, docs
…apper for Firefall - docs
…apper for Firefall - more doc tweaks & corrections
swetabar
reviewed
Nov 13, 2024
arumsey
reviewed
Nov 13, 2024
arumsey
reviewed
Nov 13, 2024
arumsey
reviewed
Nov 13, 2024
arumsey
reviewed
Nov 13, 2024
…apper for Firefall - PR comments
…apper for Firefall - PR comments
|
This PR will trigger no release when merged. |
…apper for Firefall - Hardcode Stage Firefall API for now
…apper for Firefall - imageUrls was array of 1 undefined
…apper for Firefall - coverage missing 1 line
…apper for Firefall - setting IMS GRP ID and assistant configuration
…apper for Firefall - assistant configuration validating
…apper for Firefall - more logging
…apper for Firefall - llmModel & responseFormat
arumsey
reviewed
Nov 15, 2024
…apper for Firefall - PR: deconstruct, test llmModel
…apper for Firefall - merge and api docs
arumsey
reviewed
Nov 18, 2024
src/controllers/assistant.js
Outdated
Comment on lines
29
to
31
| * There are certain commands that can be executed by the assistant. Depending on the command | ||
| * there has to be certain inputs such as prompt and imageUrl. A call is made to | ||
| * Firefall, and the response is returned. |
There was a problem hiding this comment.
Suggested change
| * There are certain commands that can be executed by the assistant. Depending on the command | |
| * there has to be certain inputs such as prompt and imageUrl. A call is made to | |
| * Firefall, and the response is returned. | |
| * There are specific commands that can be executed by the assistant. Depending on the command | |
| * there will be required inputs, such as prompt and imageUrl. A call is made to | |
| * Firefall, and the response is returned. |
src/support/assistant-support.js
Outdated
| findBlockCells: { | ||
| parameters: ['prompt', 'imageUrl'], | ||
| firefallArgs: { | ||
| llmModel: 'gpt-4-vision', |
There was a problem hiding this comment.
Suggested change
| llmModel: 'gpt-4-vision', | |
| llmModel: 'gpt-4-turbo', |
src/support/assistant-support.js
Outdated
| }, | ||
| }, | ||
| findBlockCells: { | ||
| parameters: ['prompt', 'imageUrl'], |
There was a problem hiding this comment.
Suggested change
| parameters: ['prompt', 'imageUrl'], | |
| parameters: ['prompt'], |
src/support/assistant-support.js
Outdated
| parameters: ['prompt'], | ||
| firefallArgs: { | ||
| llmModel: 'gpt-4-turbo', | ||
| responseFormat: 'json_object', |
There was a problem hiding this comment.
remove this line
Suggested change
| responseFormat: 'json_object', |
…apper for Firefall - javadocs & parameter touch-ups
arumsey
approved these changes
Nov 18, 2024
solaris007
pushed a commit
that referenced
this pull request
Nov 18, 2024
# [1.76.0](v1.75.19...v1.76.0) (2024-11-18) ### Features * SITES-26526 Import Assistant service phase 1 ([#573](#573)) ([a7b5f0c](a7b5f0c))
|
🎉 This PR is included in version 1.76.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Import Assistant endpoint (phase 1). See Jira for more details.
Related Issues
https://jira.corp.adobe.com/browse/SITES-26526