Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is correct way to use dependencies on both of addon and dummy app? #218

Open
peyloride opened this issue Jan 18, 2021 · 1 comment
Open

Comments

@peyloride
Copy link

So I have two addons. One of it depends on another. For example Addon A depends on Addon B.

I want to import styles from Addon B, in Addon A but I can't seem get it to work. What is the proper way of doing this? I tried something like this:

addon-a/app/styles/addon-a.scss

@import 'addon-b';
@import 'pod-styles';

But when building the Addon A (via ember build), this file is not processed at all (i dont know why). It looks for addon.scss instead. And failing the build due to missing mixin which declared on addon-b.

Also due to written logic on some components, i need exact same css on dummy folder. I presume I can simply do @import 'addon-a'; at dummy folder but I couldn't try yet.

@ohcibi
Copy link

ohcibi commented Apr 22, 2021

For now I'd require the developer to import all addon styles in the right order. The addon.scss logic is broken and imo an anti pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants