Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Orka #4903

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add support for Orka #4903

merged 1 commit into from
Dec 11, 2023

Conversation

smlambert
Copy link
Contributor

@smlambert smlambert commented Dec 5, 2023

Fixes #4899

Update PLATFORM_MAP with Orka dynamic agent for Mac platforms

Signed-off-by: Shelley Lambert <[email protected]>
@smlambert
Copy link
Contributor Author

Grinder on aarch64_mac: https://ci.adoptium.net/view/Test_grinder/job/Grinder/8139/

@smlambert
Copy link
Contributor Author

Grinder running extended.openjdk in PARALLEL=Dynamic across 5 machines x86-64_mac:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/8140

@sophia-guo
Copy link
Contributor

This PR is eventually needed.

However this might not be the fix for #4899. See my comment in #4899

I run a grinder with master which still works for mac aarch64 as in grinder the ACTIVE_NODE_TIMEOUT will be set as 15 min.
https://ci.adoptium.net/view/Test_grinder/job/Grinder/8154/console

@sophia-guo
Copy link
Contributor

Also feels like this orka's configuration is different from azure linux dynamic agent ones. Azure dynamic ones works like if there is no available agent then we add label &&ci.agent.dynamic, and dynamic agent will be generated. This orka one is if label [ci.role.test&&hw.arch.aarch64&&(sw.os.osx||sw.os.mac)](https://ci.adoptium.net/label/ci.role.test&&hw.arch.aarch64&&%28sw.os.osx%7C%7Csw.os.mac%29) agent not available it will be generated with label ci.role.test&&hw.arch.aarch64&&(sw.os.osx||sw.os.mac), that means no label 'ci.agent.dynamic'. Can't see the configuration and not sure if it's the final configuration. Depends on that logic on aqa-tests need to update correspondingly.

@sophia-guo
Copy link
Contributor

In short the orka test agent is used in a different way from the current dynamic agents logic is aqa-tests.

@smlambert
Copy link
Contributor Author

@sophia-guo - by your comment, do you feel this PR, adoptium/ci-jenkins-pipelines#853 is a preferred approach? If so, I can close this one and move that one out of draft.

@karianna karianna merged commit b1900b4 into adoptium:master Dec 11, 2023
1 check passed
karianna added a commit that referenced this pull request Dec 11, 2023
@karianna
Copy link
Contributor

Ugh sorry, pulled the trigger too fast - reversal PR #4913

smlambert pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke tests failing on aarch64 mac platforms (related to Orka dynamic agents)
4 participants