Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unzip of the jdk under test fails on test-osuosl-aix72-ppc64-1 #1758

Closed
lumpfish opened this issue Dec 10, 2020 · 19 comments
Closed

unzip of the jdk under test fails on test-osuosl-aix72-ppc64-1 #1758

lumpfish opened this issue Dec 10, 2020 · 19 comments

Comments

@lumpfish
Copy link

Tests fail to run on test-osuosl-aix72-ppc64-1 because the unzip of the jdk under test fails:
Failing job: https://ci.adoptopenjdk.net/view/Failing%20Test%20Jobs/job/Test_openjdk11_j9_sanity.functional_ppc64_aix/31/console
Output at time of failure:

10:46:52  + ./openjdk-tests/get.sh -s /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_ppc64_aix -t /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_ppc64_aix/openjdk-tests -p ppc64_aix -r upstream -j 11 -i openj9 --openj9_repo https://github.com/eclipse/openj9.git --openj9_branch master --tkg_repo https://github.com/AdoptOpenJDK/TKG.git --tkg_branch master
10:46:52  TESTDIR: /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_ppc64_aix/openjdk-tests
10:46:52  get jdk binary...
10:46:52  --sdkdir is set to upstream. Therefore, skip download jdk binary
10:46:52  unzip file: OpenJDK11U-jdk_ppc64_aix_openj9_2020-12-10-09-13.tar.gz ...
10:47:03  unzip file: OpenJDK11U-jre_ppc64_aix_openj9_2020-12-10-09-13.tar.gz ...
10:47:07  unzip file: OpenJDK11U-testimage_ppc64_aix_openj9_2020-12-10-09-13.tar.gz ...
10:47:10  unzip OpenJDK11U-debugimage_ppc64_aix_openj9_2020-12-10-09-13.tar.gz in ./j2sdk-image...
10:47:13  File --strip not present in the archive.
10:47:13  File 1 not present in the archive.

Maybe the version of tar on the machine doesn't support --strip?

@sxa sxa added the os:aix label Dec 10, 2020
@sxa
Copy link
Member

sxa commented Dec 10, 2020

--strip is not a standard tar operation, although I thought we'd removed most uses of GNU specific options in the test code as being mandatory

The AIX72 machines are the new ones we've added in recently via #1644

@aixtools
Copy link
Contributor

I created a .profile for the jenkins user with:

-bash-5.0$ cat .profile
PATH=/opt/freeware/bin:${PATH}
export PATH

If this fixes this - then we can add this bit to the aixPB: for the jenkins_user role.

@lumpfish
Copy link
Author

test-osuosl-aix72-ppc64-1 test now passing: https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.openjdk_ppc64_aix/289/console (Dec 13, 2020 6:39 PM ).

test-osuosl-aix72-ppc64-2 failing with same issue: https://ci.adoptopenjdk.net/job/Test_openjdk8_j9_sanity.functional_ppc64_aix/80/console (Dec 13, 2020 7:01 PM ).

@andrew-m-leonard
Copy link
Contributor

I've taken https://ci.adoptopenjdk.net/computer/test-osuosl-aix72-ppc64-2/ offline until this is fixed

@andrew-m-leonard
Copy link
Contributor

@Haroon-Khel looks like this still failed last night on test-osuosl-aix72-ppc64-2
https://ci.adoptopenjdk.net/view/Failing%20Test%20Jobs/job/Test_openjdk11_j9_sanity.functional_ppc64_aix/39/console

@andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Dec 16, 2020

@Haroon-Khel I added a bit of debug, and it's still picking up the wrong "tar":

10:36:22  /usr/bin/tar
10:32:20  PATH=/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java6/jre/bin:/usr/java6/bin

@andrew-m-leonard
Copy link
Contributor

Machine
test-ibm-aix71-ppc64-1 node has it set correctly

11:12:23  PATH=/opt/freeware/bin:/opt/IBM/xlC/13.1.3/bin:/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java7_64/jre/bin:/usr/java7_64/bin

@andrew-m-leonard
Copy link
Contributor

I've added the update to PATH to the Jenkins Node Configuration, as I saw LIBPATH was already done the same way:
image

@andrew-m-leonard
Copy link
Contributor

The other AIX machines seem to set the PATH in /etc/environment, which should work also, not sure which is best.

@aixtools
Copy link
Contributor

imho: it is better to have it in the jenkins settings - because having it in the environment breaks standard AIX management commands. GNU versions are not compatible - the most noticeable being grep. Sadly, GNU has repeatedly refused to add the paragraph (-p) option.

So, as AIX admin - request that these kinds of settings be at user (account) level, rather than expecting them at global level.

@aixtools
Copy link
Contributor

aixtools commented Dec 16, 2020

The problem on test-osuosl-aix72-ppc64-2 was a missing execute bit on .profile:

-bash-5.0$ cat .profile
PATH=/opt/freeware/bin:${PATH}
export PATH
-bash-5.0$ ls -l .profile
-rw-r--r-- 1 jenkins staff 43 Dec 15 08:01 .profile
-bash-5.0$ chmod u+x .profile
-bash-5.0$

Should work normally now - since it seems to have fixed it on test-osuosl-aix72-ppc64-1

Waiting for some other merges on aixPB. I'll add this setting to the jenkins_user part of the aixPB.

update: just tested - .profile seems to be processed regardless of 'x' bit. Must be a bash thing.

@karianna
Copy link
Contributor

So is this resolved?

@andrew-m-leonard
Copy link
Contributor

openj9 AIX & mac failed to build last night due to cross_compile error, so we haven't had a test run through yet..

@sxa
Copy link
Member

sxa commented Dec 17, 2020

I'm not sure .profile will be used for jobs run through jenkins ...

@andrew-m-leonard
Copy link
Contributor

I'm not sure .profile will be used for jobs run through jenkins ...

Correct, from what i've read it isn't

@aixtools
Copy link
Contributor

aixtools commented Jan 8, 2021

On AIX - without changing anything on AIX - you could use gtar as that is a symbolic link to the GNU tar installed in /opt/freeware/bin.

However, in the interests of speed I have setup both AIX 7.2 systems with the following:

# ls -l gtar* tar*
lrwxrwxrwx    1 root     system           26 Jul 29 2019  gtar -> ../../opt/freeware/bin/tar
lrwxrwxrwx    1 root     system           29 Jul 29 2019  gtar_32 -> ../../opt/freeware/bin/tar_32
lrwxrwxrwx    1 root     system           29 Jul 29 2019  gtar_64 -> ../../opt/freeware/bin/tar_64
lrwxrwxrwx    1 root     system            4 Jan 08 06:57 tar -> gtar
-r-xr-xr-x    1 bin      bin           85299 Jul 05 2018  tar.aix

@aixtools
Copy link
Contributor

aixtools commented Jan 8, 2021

I'm not sure .profile will be used for jobs run through jenkins ...

Correct, from what i've read it isn't

Perhaps this would need the creation, or update, of .bashrc and/or .kshrc

@sxa
Copy link
Member

sxa commented Oct 1, 2021

The PR listed above stops using strip so this has been resolved, just wasn't closed along with the issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants