Always show 0% and 100% on state of charge diagram #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadrash2108
reviewed
Oct 8, 2020
grafana/dashboards/charge-level.json
Outdated
| @@ -167,8 +167,8 @@ | |||
| "format": "percent", | |||
| "label": "Charge Level", | |||
| "logBase": 1, | |||
| "max": null, | |||
| "min": null, | |||
| "max": 100, | |||
There was a problem hiding this comment.
I believe this should be "100" (with the quotes) - when editing in Grafana directly it also makes quotes around the numbers...
roadrash2108
suggested changes
Oct 8, 2020
This affects: - the charge level panel the overview dashboard - the charge level dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the beginning of recording data with teslamate it's likely that the SoC hasn't gone down close to 0. However the minimum value in the diagram is determined by the minimum SoC recorded in TeslaMate. The resulting diagram is arguably misleading.
This PR fixes that by fixing the minimum and maximum values for the SoC diagram to 0 and 100 respectively.
Caveat: I didn't test this change.