-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the shared_preferences_tools
DevTools extension with the shared_preferences
package
#2
Comments
hey @kenzieschmoll So sorry about the delay! I missed the notification for this issue. Yes! I'd be glad to add it to the shared_preferences package! That was my initial idea, I've been studying the devtools_extensions package and the ultimate goal was to indeed open a PR adding it to shared_preferences. I saw the discussion in this issue and I think I can remove all the third party dependencies from the code. |
hey @kenzieschmoll I can't post in the main issue: |
But answering your question here: I can remove all packages that are not from the dart/flutter team. I'd need to keep only: dependencies:
devtools_extensions: ^0.0.10
devtools_app_shared: ^0.0.5
vm_service: ^13.0.0
dev_dependencies:
mockito: ^5.4.4 If I could keep |
By the way, I don't know if you remember me, but I once proposed a PR to the devtools project. The PR suggested adding Riverpod tools before the devtools extension was available. |
Nice to interact with you again! Btw I just created a tracking issue for that effort so that it does not get lost: rrousselGit/riverpod#3541.
I just unlocked the conversation on the flutter/flutter issue, so please add your comments there, thanks! |
Thanks @kenzieschmoll! Gonna cross post there. |
Have you considered adding your extension to the
shared_preferences
package directly instead of shipping it as a separate packageshared_preferences_tools
? If you were to move this extension into the upstream packageshared_preferences
, any user who depends onshared_preferences
would automatically have access to the extension.This could help with adoption since the tool you've built would be more discoverable for existing users of the
shared_preferences
package. I filed a separate issue on the flutter/flutter repo for visibility: flutter/flutter#145433The text was updated successfully, but these errors were encountered: