diff --git a/.github/workflows/build_release.yml b/.github/workflows/build_release.yml index 83c2368e5d..ce971f3602 100644 --- a/.github/workflows/build_release.yml +++ b/.github/workflows/build_release.yml @@ -1,10 +1,12 @@ -name: Build, deploy and release +name: build_release on: push: tags: - "[0-9]+.[0-9]+.[0-9]+" - "test-[0-9]+.[0-9]+.[0-9]+" + branches: + - "main" jobs: build_web: @@ -200,7 +202,7 @@ jobs: create_release: needs: [build_web, build_ios, build_android_play, build_android] - if: startsWith(github.ref_name, 'test-') != true + if: startsWith(github.ref_name, 'test-') != true && startsWith(github.event.ref, 'refs/tags/') runs-on: ubuntu-latest permissions: diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index cbdb71bdf8..8554100eba 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -1,4 +1,5 @@ -name: build & push docker container +name: docker + on: push: branches: diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 4be5b8c66c..3fb44a72cb 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -1,8 +1,8 @@ -name: Run e2e tests +name: e2e + on: workflow_dispatch jobs: playwright: - name: Run Playwright tests runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9c6d578796..3f3b996cdf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,4 +1,4 @@ -name: Cut a release +name: release on: workflow_dispatch: @@ -14,7 +14,6 @@ env: jobs: app_build_number: - name: Calculate app build number runs-on: ubuntu-latest steps: - id: calculate @@ -27,7 +26,6 @@ jobs: validate_version: needs: app_build_number - name: Validate version runs-on: ubuntu-latest outputs: version: ${{ steps.get_current_version.outputs.version }} @@ -55,7 +53,6 @@ jobs: push_release: needs: [validate_version, app_build_number] - name: Add version to apps, push release branch and tag runs-on: ubuntu-latest steps: @@ -92,9 +89,9 @@ jobs: git config --global user.email "voyager.ci.noreply@harding.dev" git config --global user.name "Voyager CI" git add . - git commit -S -m "Release ${{ needs.validate_version.outputs.version }} (${{ needs.app_build_number.outputs.app_build }})" + git commit -S -m "release: ${{ needs.validate_version.outputs.version }} (${{ needs.app_build_number.outputs.app_build }})" TAG_NAME="${TAG_PREFIX}${{ needs.validate_version.outputs.version }}" echo "Creating tag: $TAG_NAME" - git tag "$TAG_NAME" + git tag -s "$TAG_NAME" git push origin "$RELEASE_BRANCH_PREFIX/${{ needs.validate_version.outputs.version }}" git push origin "$TAG_NAME" diff --git a/.github/workflows/semantic_pull_request.yml b/.github/workflows/semantic_pull_request.yml new file mode 100644 index 0000000000..02e902d0e0 --- /dev/null +++ b/.github/workflows/semantic_pull_request.yml @@ -0,0 +1,24 @@ +name: semantic_pull_request + +on: + pull_request_target: + types: + - opened + - edited + - synchronize + +jobs: + main: + if: github.repository == 'aeharding/voyager' + runs-on: ubuntu-latest + steps: + - name: Validate PR title + uses: amannn/action-semantic-pull-request@v5 + with: + subjectPattern: ^(?![A-Z]).+$ + subjectPatternError: | + The subject "{subject}" found in the pull request title "{title}" + didn't match the configured pattern. Please ensure that the subject + doesn't start with an uppercase character. + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 2e45267318..0f907c5188 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -41,8 +41,10 @@ platform :ios do ipa: ENV['ios_output'], app_identifier: ENV['app_identifier'], api_key_path: "authkey.json", - skip_waiting_for_build_processing: true, - changelog: "Upload from GitHub Actions, ref #{ENV['GITHUB_REF']}, sha #{ENV['GITHUB_SHA']}, msg #{ENV['COMMIT_MSG']}" + distribute_external: true, + groups: ["Public Testers"], # want to join? https://testflight.apple.com/join/nWLw1MBM + changelog: "Upload from GitHub Actions, ref #{ENV['GITHUB_REF']}, sha #{ENV['GITHUB_SHA']}, msg #{ENV['COMMIT_MSG']}", + reject_build_waiting_for_review: true, ) end end @@ -64,9 +66,9 @@ platform :android do if !ENV['GITHUB_REF_NAME'].start_with?('test-') upload_to_play_store( package_name: ENV['app_identifier'], - release_status: 'draft', - json_key: ENV['google_service_account_path'], aab: Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH], + json_key: ENV['google_service_account_path'], + track: 'beta', skip_upload_apk: true, skip_upload_metadata: true, skip_upload_images: true,