Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips not readable when loading Git Updater settings on mobile #1001

Open
jessuppi opened this issue Sep 27, 2022 · 6 comments
Open

Tooltips not readable when loading Git Updater settings on mobile #1001

jessuppi opened this issue Sep 27, 2022 · 6 comments

Comments

@jessuppi
Copy link

Hey @afragen and thanks for your hard work with Git Updater. I have been following it for the last few years and just recently started digging into things more.

One thing I noticed is the "tooltips" under Settings >> Git Updater >> GitHub tab don't work on mobile. Even when clicking on them nothing displays, even when I changed my mobile device to force load a Desktop version.

Perhaps some layout tweaks would help resolve that. Cheers!

@afragen
Copy link
Owner

afragen commented Sep 27, 2022

I'm pretty sure that's an issue with mobile not being able to display a hover element. If you have any ideas about that I'm open to them.

@jessuppi
Copy link
Author

There are a few CSS-only solutions using pseudo classes that might work:

Ref: https://stackoverflow.com/a/60660207/1718491

Or perhaps not using a tooltip at all, and just adding the warning/error in a WP Admin notice or something?

@afragen
Copy link
Owner

afragen commented Sep 27, 2022

I try to keep admin notices to a minimum.

@afragen
Copy link
Owner

afragen commented Sep 27, 2022

I'm open to discussing a PR.

@jessuppi
Copy link
Author

Should PRs be sent to the Develop branch for Git Updater?

@jessuppi
Copy link
Author

Worth mentioning that layout adjustments being discussed in another Issue might negate the need for a patch, although if I can figure out an easy CSS patch in the meantime I will definitely send a PR.

Ref: #1002 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants