Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming from update services #262

Closed
afragen opened this issue Jul 9, 2015 · 4 comments
Closed

Renaming from update services #262

afragen opened this issue Jul 9, 2015 · 4 comments
Labels

Comments

@afragen
Copy link
Owner

afragen commented Jul 9, 2015

It seems renaming from update services like iThemes Sync, ManageWP, and likely others is broken.

I'm reaching out to iThemes for help in figuring out the problem.

@afragen afragen added the bug label Jul 9, 2015
@afragen
Copy link
Owner Author

afragen commented Jul 10, 2015

I think I see the issue. In Base::_get_updating_repos() I parse the $_REQUEST variable.

https://github.com/afragen/github-updater/blob/develop/src/GitHub_Updater/Base.php#L525-L530

The $_REQUEST variable structure must be different for iThemes Sync, ManageWP, etc. and once I can get that info this should be fixed.

@afragen
Copy link
Owner Author

afragen commented Jul 11, 2015

iThemes Sync is now working again. Thanks @chrisbliss18

@afragen
Copy link
Owner Author

afragen commented Jul 17, 2015

Just was listening to Apply Filters with @pippinsplugins and thought I should really just add a couple of hooks into the right places and figure out how to add support for remote update services via additional small classes.

@afragen
Copy link
Owner Author

afragen commented Jul 22, 2015

I've been testing with a local install of InfiniteWP and every seems to work. The only exceptions are that InfiniteWP doesn't seem to identify child themes for updates.

@afragen afragen changed the title Renaming from update services broken Renaming from update services Jul 22, 2015
@afragen afragen added testing and removed bug labels Jul 22, 2015
@afragen afragen added fixed and removed testing labels Apr 19, 2016
@afragen afragen closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant