-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PasswordAndConfirmationInput
leftover
#760
Comments
PasswordAndConfirmationInput
leftoversPasswordAndConfirmationInput
leftover
can i work on this issue |
Thanks a lot, but @balsa-asanovic already picked it and I don't know if he already committed the fixes in his local branch. Maybe you guys can coordinate if it isn't done yet. In any case, I'll try to look for more good-first-issues in the incoming days :) BTW, welcome to the Agama project 👋 |
Hey @avdhendra, I was already working on this component as a part of #750 when the issue was raised, so I took care of it since it wasn't a big change. Sorry for taking a 'good first issue' from you 😅 Be sure to follow the issues, I am sure another one will pop up. |
While reviewing #750, I realized that
PasswordAndConfirmationInput
has a leftover split prop.Initially it was there to allow choosing between a vertical or horizontal layout but actually it was never used. In any case, we should go for a direction prop instead if we really need something similar the future.
For now, I'd just drop both, the prop and the wrapping div.
https://github.com/openSUSE/agama/blob/2d4284241bbd3b0960df06f2a442f9d22dc6e74a/web/src/components/core/PasswordAndConfirmationInput.jsx#L29-L57
Just a good-first-issue or something to commit in #750, #759, or later.
The text was updated successfully, but these errors were encountered: