Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplayGain support #131

Open
jansol opened this issue Feb 28, 2021 · 2 comments
Open

ReplayGain support #131

jansol opened this issue Feb 28, 2021 · 2 comments

Comments

@jansol
Copy link

jansol commented Feb 28, 2021

Counts as a must-have feature for me. With the wide variety of styles in my library a plain volume setting isn't sufficient as files can have very different loudness (especially in shuffle all mode which I use a lot).

The usual "auto" behavior for replaygain is to use track gain when shuffle is on and album gain when it's not. Most players also allow users to choose auto, always track gain and always album gain.

The easiest way to handle this is probably to modulate the user-set playback volume with the track/album gain found in the file's tags. I believe youtube is doing something like this, considering that they show the set/adjusted volume in Stats for Nerds.

@jansol
Copy link
Author

jansol commented Mar 1, 2021

Moved the playback side of things to polaris-web, since that's where it belongs.

Now scanning replaygain for files that are missing the relevant tags would be relevant to this repo and could be nice but I'd rather not have polaris write anything to my music files without my explicit approval (I have beets taking care of all tagging). Keeping that info in the db would be one option if the user doesn't allow writing new tag data.

@agersant
Copy link
Owner

agersant commented Mar 2, 2021

Agreed this would be a valid addition. I do think Polaris should only worry about reading existing replay gain tags, writing metadata has always been left to users' preferred solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants