Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to signature_pad v4 for "passive" events? #73

Open
DrMeers opened this issue Mar 1, 2022 · 4 comments
Open

Update to signature_pad v4 for "passive" events? #73

DrMeers opened this issue Mar 1, 2022 · 4 comments
Labels
kind: optimization Performance, space, size, etc improvement scope: dependencies Pull requests that update a dependency file scope: upstream Issue in upstream dependency solution: duplicate

Comments

@DrMeers
Copy link

DrMeers commented Mar 1, 2022

package.json seems to lock us into using version 2.3.2 of signature_pad, rather than the latest 4.0.2. I noticed because I encountered this error:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

and upon searching, found it has already been fixed in szimek/signature_pad#308 years ago . Are we able to take advantage of the upstream fixes?

@agilgur5 agilgur5 changed the title Using outdated version of signature_pad? Update to signature_pad v4? Mar 1, 2022
@agilgur5 agilgur5 added kind: optimization Performance, space, size, etc improvement scope: dependencies Pull requests that update a dependency file scope: upstream Issue in upstream dependency labels Mar 1, 2022
@agilgur5 agilgur5 changed the title Update to signature_pad v4? Update to signature_pad v4 for "passive" events? Mar 1, 2022
@agilgur5
Copy link
Owner

agilgur5 commented Mar 1, 2022

See detailed discussion in #68 with regards to updating.

szimek/signature_pad#308 was released in v3.0.0-beta.1, and per the discussion above, v3 never came out of beta and v4 was just recently released instead.

As far as I'm aware, the log you've output here is just a performance warning, and not blocking. react-signature-canvas and signature_pad v2 etc have been used in production for many years without significant performance issues.
Have labeled this as an optimization and not high priority as such.

@DrMeers
Copy link
Author

DrMeers commented Mar 1, 2022

Great, thanks for the info and prompt response @agilgur5 !

@agilgur5 agilgur5 added this to the `signature_pad` v4 milestone Apr 4, 2022
@djberg96

This comment was marked as spam.

@agilgur5
Copy link
Owner

Any updates would be in the thread already. The changes are breaking in multiple ways, including ways not really known by one of the maintainers per #68, and no one has contributed an update to v4 that addresses breaking changes. Anyone is more than welcome to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: optimization Performance, space, size, etc improvement scope: dependencies Pull requests that update a dependency file scope: upstream Issue in upstream dependency solution: duplicate
Projects
None yet
3 participants