Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only formatting changed files #6

Closed
Riley19280 opened this issue May 2, 2023 · 2 comments
Closed

Support only formatting changed files #6

Riley19280 opened this issue May 2, 2023 · 2 comments

Comments

@Riley19280
Copy link

When setting up this action, I expected the onlyDirty: true argument to only format changed files in the PR, since this is a fairly common use case for linting. However, it did not format anything, because all changes are already committed, and that is how Pint works.

I propose adding an option onlyChanged that would only format the files changed in the PR/commit. This was referenced in #5 (comment), and a workaround was given, to use another action to format only changed files. However, using the get all changed files action, I don't see any way that I would pass a list of files to format to Pint.

@aglipanci
Copy link
Owner

@Riley19280 you are welcome to create a PR for this, it's not on my plans to work on this feature in particular anytime soon.

@sergotail
Copy link

@Riley19280 i've implemented the same action, but tried to address issues of current package, maybe it will help: https://github.com/sergotail/laravel-pint-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants