-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting ECONNRESET error #448
Comments
Update: downgrading to the previous version (1.18.1) fixes the issue. |
Do you have sample code/images? |
Getting the same issue. Almost anything uploaded will fail when trying to .size() on 1.19.0 – 1.18.1 is fine. Will try and put some more info together, but it's pretty consistent... |
same here, will try to isolate and report. |
#446 is probably related. A quick fyi. I've no idea if gm works in node 4.0 (or 4.1) I've not tried it and due to the fast development pace of the 4.x branch I'll wait a bit before trying it. If someone can put up reproducible code and images by Monday I can take a look next week, all tests are passing so it must be something we don't test for 😞 |
@rwky, isolated it to large jpg/png. Please have a look at: https://github.com/vast/gm-448
|
Excellent, I can reproduce it using that repo, leave it with me. |
This is really weird. I've pinned it down to this line Line 77 in 38f5f55
For some reason adding png: before - causes gm to close the pipe early (I'm assuming it's gm and not node being weird). Unless anyone else can come up with a better solution I'll have to revert that commit which is a shame since it's useful. |
Same here on debian/sid when generating large (750x19000) jpg with |
Not just large images, I'm getting this with small jpgs (580 x 320 ~ <100kb) as part of a Gulp task using gulp-image-resize OSX 10.10.5 |
Can someone please test the issue-448 branch and confirm that this is resolved? If so I'll merge it in and release a new version to npm. |
@rwky i can confirm that it works |
OK 1.20.0 is in npm I'll close this. |
@rwky it's gm that closes the pipe early. I've faced this issue randomly, depending on the system I tested it on, but in each case I could reproduce it with:
The result is always unaltered. I assume it is the expected behaviour from gm since it doesn't create a temp file in the second case and may therefore not need to wait for the whole file. The missing total file size (2.2M) comfort this idea. It seems also slightly faster (testing with wget). Ignoring the broken pipe should be safe in this case. |
OS: Ubuntu 14.04.
Both Imagemagick and GraphicMagick are installed.
gm version: 1.19.0
GraphicMagick version: 1.3.18.
Stacktrace:
Any help or ideas?
The text was updated successfully, but these errors were encountered: