Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA failures in aiidalab-launch #163

Open
danielhollas opened this issue Jan 2, 2023 · 7 comments
Open

GHA failures in aiidalab-launch #163

danielhollas opened this issue Jan 2, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@danielhollas
Copy link
Contributor

Tests seem to be timing out randomly on GHA (e.g. after 30 minutes).
Interestingly, the pytest tests seem to always finish fine, but then the workflow step gets stuck? Very strange...

See for example

https://github.com/aiidalab/aiidalab-launch/actions/runs/3550589631/jobs/5972824480

@danielhollas
Copy link
Contributor Author

Maybe duplicate of #154, see discussion there.

@unkcpz
Copy link
Member

unkcpz commented Jan 10, 2023

thanks for reporting this @danielhollas. When #154 happened, it is stuck in the command line rather than printing an error message and exiting so you can type new on the terminal, correct?

@danielhollas
Copy link
Contributor Author

It is stuck and I needed to the Ctrl+C and only then the error was printed.

@unkcpz
Copy link
Member

unkcpz commented Jan 10, 2023

I see, I'll take a look at #154. The error seems like the async function is called from another coroutine directly without await.

@danielhollas
Copy link
Contributor Author

Yeah. Just note from the discussion there that Simon already spent some time on it and couldn't figure it out, so it might be a pain, maybe not the biggest priority now, although it is annoying.

btw: Could you make a release of aiidalab-launch. I'd like to start using the two minor improvements that I implemented. Thanks!

@unkcpz
Copy link
Member

unkcpz commented Jan 10, 2023

Sure, I'll make the release. Thanks a lot for the fixes!

@danielhollas danielhollas changed the title GHA failures GHA failures in aiidalab-launch Feb 1, 2023
@danielhollas danielhollas self-assigned this Feb 1, 2023
@danielhollas danielhollas added the bug Something isn't working label Feb 1, 2023
@danielhollas
Copy link
Contributor Author

In failures here and here),the test suite no longer times out, but actually fails in a reasonable amount of time. The failures are too generic to pinpoint the issue, since it says the container fails to start. Probably more debug logging is needed to debug this, we need the pytest to somehow print the container logs when it fails to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants