Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions/suggestions on documentation page about workflows #1927

Closed
borellim opened this issue Aug 31, 2018 · 3 comments
Closed

Questions/suggestions on documentation page about workflows #1927

borellim opened this issue Aug 31, 2018 · 3 comments

Comments

@borellim
Copy link
Member

I have a few questions / suggestions about this page of the documentation that discusses workflows.

  • Can the ctx member of a WorkChain be equivalently accessed as a dictionary (self.ctx['key']) and with the dot notation (self.ctx.key)? This seems implied but is not made explicit.

  • The use of the agglomerate argument is not super clear to me, especially in the case of exposed_outputs(). They name of the argument itself also doesn't seem very intuitive. Maybe I just need to make use of the feature in order to understand its necessity.

  • To better understand the last complex example, I took the liberty of making a graph: feel free to use it (or not). Note however that, in order to make the graph clearer, I had to slightly change the ChildWorkChain so that it creates new outputs, rather than simply passing the inputs along:

    def do_run(self):
        self.out('d', Int(self.inputs.a*2))
        self.out('e', Float(self.inputs.b*2))
        self.out('f', Bool(not self.inputs.c))

57665.pdf

@sphuber sphuber added this to the v1.0.0 milestone Dec 3, 2018
@sphuber sphuber added type/task good first issue Issues that should be relatively easy to fix also for beginning contributors topic/workflows topic/code-structure priority/nice-to-have labels Dec 3, 2018
@sphuber sphuber self-assigned this Dec 3, 2018
@sphuber sphuber modified the milestones: v1.0.0, v1.1.0 Apr 3, 2019
@sphuber sphuber removed this from the v1.1.0 milestone Feb 28, 2020
@sphuber sphuber removed their assignment Oct 20, 2020
@ramirezfranciscof ramirezfranciscof self-assigned this Oct 21, 2020
@mbercx mbercx self-assigned this Oct 21, 2020
@ramirezfranciscof ramirezfranciscof removed their assignment Oct 23, 2020
@unkcpz
Copy link
Member

unkcpz commented Nov 11, 2021

Hi @borellim, could you check the current documentation is good enough for your questions mentioned above? I think it is safe to close this issue @mbercx correct?

@unkcpz unkcpz removed the good first issue Issues that should be relatively easy to fix also for beginning contributors label Nov 11, 2021
@borellim
Copy link
Member Author

borellim commented Nov 11, 2021

Thanks Jason. I don't use AiiDA any more now, so I'm not sure that my input would be valuable. But I do appreciate your following up.

EDIT: Also the link above does not work any more...

@unkcpz
Copy link
Member

unkcpz commented Nov 11, 2021

Thanks Marco! To me, the problem you mentioned is now nicely documented thanks to their efforts on documentation ;-)
Will close this for now.

@unkcpz unkcpz closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants