Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect check in aiida.cmdline.utils.decorators.load_backend_if_not_loaded causes backend to sometimes not be loaded #4877

Closed
sphuber opened this issue Apr 28, 2021 · 1 comment · Fixed by #4878
Closed

Incorrect check in aiida.cmdline.utils.decorators.load_backend_if_not_loaded causes backend to sometimes not be loaded #4877

sphuber opened this issue Apr 28, 2021 · 1 comment · Fixed by #4878
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release topic/utilities topic/verdi type/bug
Milestone
v1.6.3

Comments

@sphuber
Copy link
Contributor

sphuber commented Apr 28, 2021

It uses the PROFILE global to determine whether a database backend has been loaded, but this global can be set without having loaded the corresponding database backend.
@sphuber sphuber added this to the v1.6.3 milestone Apr 28, 2021
@sphuber sphuber self-assigned this Apr 28, 2021
@chrisjsewell
Copy link
Member

chrisjsewell commented Apr 28, 2021 •
edited
Loading

To add some extra detail, this regression occurs only in 1.6.2 (due to #4865) and manifests in e.g. verdi archive import failing: https://github.com/marvel-nccr/ansible-role-aiida/pull/72/checks?check_run_id=2457849742

@sphuber sphuber mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release topic/utilities topic/verdi type/bug
Projects
None yet
Milestone
v1.6.3
Development

Successfully merging a pull request may close this issue.

Fix aiida.cmdline.utils.decorators.load_backend_if_not_loaded sphuber/aiida-core
2 participants
@chrisjsewell @sphuber