Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure key external packages/plugins are updated to 2.0 #5284

Closed
2 tasks
giovannipizzi opened this issue Dec 17, 2021 · 3 comments
Closed
2 tasks

Make sure key external packages/plugins are updated to 2.0 #5284

giovannipizzi opened this issue Dec 17, 2021 · 3 comments
Labels
type/feature request status undecided

Comments

@giovannipizzi
Copy link
Member

A number of key external packages and plugins should be updated to make sure they work with 2.0.

I suggest to do the work as soon as the RC is out (mid Jan?), to make sure that key packages are updated before the actual release (1 month should be enough?)
Linking to #5282 as this is also related to checking warnings (but due to external packages issuing warnings, or even crashing, rather than aiida-core itself).

I add here a few things to check, feel free to add comments or edit this description to add more, and we can track progress here.

  • encourage all plugins to support 2.0, and to replace their dependencies from <2.0 to <3.0 (now installing any plugin like this will actually revert AiiDA's version to 1.6.5 which is pretty annoying if people don't realise they are installing an older version). Actually if anybody has some clever idea on how to avoid that people have to keep reverting downgrades would be great as I see this as a common problem for a few months - but I don't know if pip allows to do this in simple way?
  • at least we should upgrade the following packages and release a new version:
    • aiida-quantemespresso (@mbercx)
    • aiida-pseudo (I noticed for instance that the CLI uses some classes that have been probably moved) (@sphuber)
    • strongly encourage all aiida-common-workflows plugins to upgrade, as well as the aiida-common-workflows package itself (@sphuber or @bosonie, and ping the various plugin developers)
    • aiida-submission-controller (@giovannipizzi)
    • aiida-wannier90 (@qiaojunfeng) and possibly related packages (like the aiida-wannier90-theosworkflows)
@giovannipizzi
Copy link
Member Author

Also, as soon as the RC of 2.0 is released, we should actively reach out to developers of plugins in various possible channels (GitHub discussion channel, AiiDA mailing list, issues in the respective repos, possibly direct contact where we know them) to ask them to actively address 2.0 compatibility (fully reading the 2.0 wiki page), ideally during the month from the RC to the release.

@sphuber
Copy link
Contributor

sphuber commented Apr 25, 2022

I am moving this to the post v2.0 milestone. We are soon releasing v2.0 and can then follow up with plugin developers to have them start using it and update the plugins

@sphuber sphuber closed this as completed Apr 25, 2022
@sphuber sphuber reopened this Apr 25, 2022
@sphuber sphuber modified the milestones: v2.0.0, Post 2.0 Apr 25, 2022
@sphuber sphuber removed this from the v2.3.0 milestone Dec 6, 2022
@sphuber
Copy link
Contributor

sphuber commented May 17, 2023

Closing this as most if not all plugins have been updated.

@sphuber sphuber closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature request status undecided
Projects
None yet
Development

No branches or pull requests

2 participants