Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional version argument into VerdiCommand that specifies when a deprecated command is removed #6463

Open
agoscinski opened this issue Jun 6, 2024 · 0 comments

Comments

@agoscinski
Copy link
Contributor

Is your feature request related to a problem? Please describe

In PR #6426 we implemented into the deprecation command decorator the version argument that allows to specify with which version a command is removed from the code base. But since the deprecation command decorator became deprecated (see replacement PR #6433, see deprecation PR #6461) we did not need it. I kept the feature in a backup PR #6462 to implement it properly in aiida.cmdline.groups.VerdiCommand.

Describe the solution you'd like

Most likely we need a new input argument in aiida.cmdline.groups.VerdiCommand that specifies the version of removal, but I keep the design as open to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant