Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verdi export create -c does not work #1033

Closed
broeder-j opened this issue Jan 9, 2018 · 3 comments
Closed

verdi export create -c does not work #1033

broeder-j opened this issue Jan 9, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@broeder-j
Copy link
Member

verdi export create --computers 2 -a tar.gz "computers_"$(date +%Y%m%d)
<Computer: iff003 (iff003), pk: 2>

fails with

 File "/Users/broeder/aiida/github/aiida_core/aiida/orm/importexport.py", line 1699, in export_tree
    raise ValueError("I was given {}, which is not a DbNode or DbGroup instance".format(entry))
ValueError: I was given iff003 (iff003), which is not a DbNode or DbGroup instance

My guess it that it apparently was able to load/get the computer, but Computer fails then in the more general functions, which do not expect that type.

Also
verdi export create --computers 1 2 3 4 -a tar.gz "computers_"$(date +%Y%m%d)

Fails with:

Usage: verdi export create [OPTIONS] OUTFILE
Error: Got unexpected extra arguments (3 4 computers_20180109)

Therefore the input parsing is not working for several pks, in the computer case.

@broeder-j
Copy link
Member Author

broeder-j commented Jan 15, 2018

update: computer exports work fine with other nodes, like codes. Also the import.
Therefore, this issue is not critical or blocking and prob a bug in the --computer export case. (Otherwise a lot more people would have noticed). But so far I do not see in the code why it should run into this at all.

If you need to export or import only computers, as a work around one can go back to version 0.9. there it works.

@szoupanos
Copy link
Contributor

szoupanos commented Jan 18, 2018

Yes, maybe we missed the case that someone wants to export only computers and no other nodes. We will have a look at that.

Thanks Jens for the report!

@szoupanos szoupanos added this to the 1.0 release milestone Jan 18, 2018
@sphuber sphuber self-assigned this Apr 19, 2018
@sphuber sphuber modified the milestones: 1.0 release, v0.12.0 Apr 19, 2018
@sphuber
Copy link
Contributor

sphuber commented Apr 20, 2018

Fixed in #1448

@sphuber sphuber closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants