Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tag release revisions in git #153

Open
risicle opened this issue May 26, 2022 · 6 comments
Open

Please tag release revisions in git #153

risicle opened this issue May 26, 2022 · 6 comments

Comments

@risicle
Copy link

risicle commented May 26, 2022

It doesn't look like there has been a tag for a release revision since 2019. Without these, figuring out the exact source corresponding the the version you're running is painful.

@pohmelie
Copy link
Collaborator

I don't get the problem, you can recognize version via python -m pip list | grep aioftp.

@risicle risicle changed the title Please tag release revisions Please tag release revisions in git May 27, 2022
@risicle
Copy link
Author

risicle commented May 27, 2022

That doesn't give you the source. It tells you a version number (if you're using pip, and not everyone is). If you then need to see the exact source corresponding to that particular version and the git details of what patches have or have not been merged into your version, you have to browse github until you figure it out. It's one of those small things that makes it much easier for a user to productively interact with the project, track down problematic PR merges, etc..

@pohmelie
Copy link
Collaborator

I don't know how you can use lib without pip... actually I can imagine this, but see no reasons for this. Anyway you install package from pypi or your distro repo. They both have version information. Every release have release commit like this f705cdf. It is more than enough to recognize exact source point of repository. Tag adds nothing here and useless.

@risicle
Copy link
Author

risicle commented May 28, 2022

The most useful thing having tags-for-versions does is make github show at a glance, for any commit, which versions that commit made it into - or if it's only in master and hasn't made it in to a release yet.

Screenshot_20220528_111029

It also allows someone to do e.g. python-ldap/python-ldap@python-ldap-3.1.0...python-ldap-3.3.1

@pohmelie
Copy link
Collaborator

This feature (if someone needs it) works fine for commits: 9118e91...f705cdf. Of course this is less readable, but I've never used such comparsions directly in github. Probably, because gitlab is popular for local usage in big companies.

@pohmelie
Copy link
Collaborator

I see likes on your comment, so I add tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants