-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redirects with changing cookie values #3576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3576 +/- ##
======================================
Coverage 97.9% 97.9%
======================================
Files 43 43
Lines 8556 8556
Branches 1376 1376
======================================
Hits 8377 8377
Misses 74 74
Partials 105 105 Continue to review full report at Codecov.
|
I apologize for missing some lint, I think there were some general build issues that made it hard for me to see that some of the breakage was caused by myself. Anyway, all fixed now. |
Sorry, I'm very busy this month. |
(cherry picked from commit 398b5ba) Co-authored-by: Anders Melchiorsen <[email protected]>
(cherry picked from commit 398b5ba) Co-authored-by: Anders Melchiorsen <[email protected]>
What do these changes do?
Fix an issue where cookies would sometimes not be set during a redirect.
When looping due to a redirect, the
cookies
variable from the previous loop would clobber thecookies
argument introduced in #3396.Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.