-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release all forgotten resources in tests #5494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5494 +/- ##
==========================================
+ Coverage 96.61% 97.17% +0.55%
==========================================
Files 41 41
Lines 8815 8857 +42
Branches 1412 1424 +12
==========================================
+ Hits 8517 8607 +90
+ Misses 167 133 -34
+ Partials 131 117 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 8c82ba1 on top of patchback/backports/3.8/8c82ba11b9e38851d75476d261a1442402cc7592/pr-5494 Backporting merged PR #5494 into master
🤖 @patchback |
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
This change makes sure to release most of the hanging resources in the lib and tests. They were detected by pytest v6.2+. PR aio-libs#5494 (cherry picked from commit 8c82ba1)
What do these changes do?
Ever since pytest got updated to v6.2, it started emitting resource
warnings under new Pythons 3.8+ which results in a failed status.
This change addresses this issue by properly most of the resources
so they don't even appear and ignoring the rest in cases of race
conditions and other cases that are hard to track down.
Are there changes in behavior for the user?
No.
Related issue number
N/A
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.