Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify auth header destiny during the redirect #5850

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

greshilov
Copy link
Contributor

@greshilov greshilov commented Jul 3, 2021

What do these changes do?

Backport of the #5848, but without the breaking change, just doc and test.

Are there changes in behavior for the user?

No.

Related issue number

Resolves #5783

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@greshilov greshilov force-pushed the redirect-auth-regression-test branch from 2925ae0 to 7a829e4 Compare August 11, 2021 18:36
@greshilov
Copy link
Contributor Author

@webknjaz PTAL

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 12, 2021
@webknjaz webknjaz enabled auto-merge (squash) August 12, 2021 13:32
@webknjaz webknjaz merged commit d11c715 into aio-libs:3.8 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants