Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update quick start demo codes #6240

Merged
merged 2 commits into from
Nov 4, 2021
Merged

update quick start demo codes #6240

merged 2 commits into from
Nov 4, 2021

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Nov 4, 2021 •
edited
Loading

What do these changes do?

just update quick start demos avoiding a warning messages.

Are there changes in behavior for the user?

None.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 4, 2021
@asvetlov asvetlov added backport-3.8 bot:chronographer:skip This PR does not need to include a change note labels Nov 4, 2021
asvetlov
asvetlov approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #6240 (04b17e7) into master (8a952c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6240   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         103      103           
  Lines       30362    30362           
  Branches     2729     2729           
=======================================
  Hits        28328    28328           
  Misses       1857     1857           
  Partials      177      177
Flag Coverage Δ
unit 93.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a952c9...04b17e7. Read the comment docs.

@asvetlov asvetlov enabled auto-merge (squash) November 4, 2021 10:47
@asvetlov asvetlov merged commit 9c316f1 into aio-libs:master Nov 4, 2021
@patchback
Copy link
Contributor

patchback bot commented Nov 4, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/9c316f12755ce4e1904337478760d926a0ff2cfb/pr-6240

Backported as #6248

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 4, 2021
@d4x1
update quick start demo codes (#6240)
f851040 
* update quick start demo codes

* add CHANGES

Co-authored-by: Lynwee.Hou <[email protected]>
(cherry picked from commit 9c316f1)
@patchback patchback bot mentioned this pull request Nov 4, 2021
Merged
5 tasks
@patchback
Copy link
Contributor

patchback bot commented Nov 4, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/9c316f12755ce4e1904337478760d926a0ff2cfb/pr-6240

Backported as #6249

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 4, 2021
@d4x1
update quick start demo codes (#6240)
41cc9ca 
* update quick start demo codes

* add CHANGES

Co-authored-by: Lynwee.Hou <[email protected]>
(cherry picked from commit 9c316f1)
@patchback patchback bot mentioned this pull request Nov 4, 2021
Merged
5 tasks
asvetlov added a commit that referenced this pull request Nov 4, 2021
@patchback @d4x1 @asvetlov
update quick start demo codes (#6240) (#6248)
515ce62 
* update quick start demo codes

* add CHANGES

Co-authored-by: Lynwee.Hou <[email protected]>
(cherry picked from commit 9c316f1)

Co-authored-by: d4x1 <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Nov 4, 2021
@patchback @d4x1 @asvetlov
update quick start demo codes (#6240) (#6249)
bab98dc 
* update quick start demo codes

* add CHANGES

Co-authored-by: Lynwee.Hou <[email protected]>
(cherry picked from commit 9c316f1)

Co-authored-by: d4x1 <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @asvetlov