Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (bf022b3) to head (9804f7a).
Report is 11 commits behind head on master.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##           master    #9200   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34483    34507   +24     
  Branches     4093     4100    +7     
=======================================
+ Hits        33901    33927   +26     
+ Misses        411      410    -1     
+ Partials      171      170    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Is it possibly caused by the exception handling or something?
https://github.com/python/cpython/blob/4420cf4dc9ef7bd3c1c9b5465fa9397304bf0110/Lib/contextlib.py#L149

Is it possibly caused by the exception handling or something? python/cpython@4420cf4/Lib/contextlib.py#L149

Yeah it looks like the __enter__ and mostly __exit__ implementation is overkill for this use case.

Is it possibly caused by the exception handling or something? python/cpython@4420cf4/Lib/contextlib.py#L149

Yeah it looks like the __enter__ and mostly __exit__ implementation is overkill for this use case.

I don't think enter is an issue. I believe try is now a 0-cost implementation in Python 3.13..

But, exit handles an exception in the expected case. I can't think of any way to make that more efficient though, other than not using the decorator...

The profile shows the most expensive part is __init__ on line 104 with cpython 3.12.4, followed by __exit__ so it looks like the context manager object has to be created every time from the helper function.

Line 108 on cpython main https://github.com/python/cpython/blob/4420cf4dc9ef7bd3c1c9b5465fa9397304bf0110/Lib/contextlib.py#L108

I recall we had a similar problem with rendering templates in Home Assistant (we can render many per second) and the solution was to create the context manager once and use it over and over... that worked because there was no await and everything finished synchronously, but we can't use that solution here.

The profile shows the most expensive part is __init__ on line 104 with cpython 3.12.4, followed by __exit__ so it looks like the context manager object has to be created every time from the helper function.

Line 108 on cpython main https://github.com/python/cpython/blob/4420cf4dc9ef7bd3c1c9b5465fa9397304bf0110/Lib/contextlib.py#L108

Looks to me like there's a ContextDecorator which uses _recreate_cm() to avoid redoing the init everytime. It seems to me like the decorators could be improved a little to do that same thing instead of instantiating a new class directly on every call. Not sure how much you'd get from that, but atleast would save fetching the docs attribute etc. in the init.