Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracket IPv6 addresses in the HOST header #3304

Closed
pollydrag opened this issue Sep 30, 2018 · 3 comments
Closed

Bracket IPv6 addresses in the HOST header #3304

pollydrag opened this issue Sep 30, 2018 · 3 comments
Labels
bug good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ outdated

Comments

@pollydrag
Copy link
Contributor

Long story short

ClientSession does not bracket the IPv6 addresses in the HOST header.

Expected behaviour

GET / HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Host: [::1]:99
User-Agent: Python/3.6 aiohttp/3.5.0a0

Actual behaviour

GET / HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Host: ::1:99
User-Agent: Python/3.6 aiohttp/3.5.0a0

Steps to reproduce

async with aiohttp.ClientSession() as client:
    await client.get('http://[::1]:99')

Your environment

  1. aiohttp 3.5.0a0
  2. python 3.6
  3. ubuntu 16.04
  4. aiohttp client
@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #1652 (Trailer headers), #116 (Host the docs), #559 (aiohttp client does not support ipv6 addresses), #3265 (Host header position causes certain sites to not respond), and #1197 (Flask request headers).

pollydrag pushed a commit to pollydrag/aiohttp that referenced this issue Sep 30, 2018
Bracket IPv6 addresses in the HOST header (aio-libs#3304)
fced49a
pollydrag pushed a commit to pollydrag/aiohttp that referenced this issue Sep 30, 2018
Bracket IPv6 addresses in the HOST header (aio-libs#3304)
85ef52d
@pollydrag pollydrag mentioned this issue Sep 30, 2018
Merged
5 tasks
@asvetlov asvetlov added the good first issue Good for newcomers label Oct 2, 2018
@webknjaz webknjaz added Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ and removed Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ labels Oct 3, 2018
asvetlov pushed a commit that referenced this issue Oct 4, 2018
@pollydrag @asvetlov
Bracket IPv6 addresses in the HOST header (#3304) (#3305)
0875f7a
@asvetlov
Copy link
Member

asvetlov commented Oct 4, 2018

Fixed by #3305

@asvetlov asvetlov closed this as completed Oct 4, 2018
@aio-libs-bot aio-libs-bot mentioned this issue Dec 19, 2018
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asvetlov @webknjaz @pollydrag @aio-libs-bot