Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Connection.wait_closed() #11

Closed
asvetlov opened this issue Apr 20, 2015 · 1 comment
Closed

rename Connection.wait_closed() #11

asvetlov opened this issue Apr 20, 2015 · 1 comment

Comments

@asvetlov
Copy link
Member

asyncio.AbstractServer uses the following idiom:

  • close() closes connection asynchronously, it's regular function.
  • wait_closed() is a coroutine that waits for actual closing.

Connection.wait_closed() has different behavior: it sends disconnection signal to server and after that closes connection.

I guess rename it to .ensure_closed().

@jettify
Copy link
Member

jettify commented Apr 21, 2015

+1. I missed idea behind wait_closed()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants