-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 5.1 migration incompatibility #949
Comments
Thanks Travis, that makes sense. How can we change our "migration template" ( |
It looks like devise uses erb to accomplish this. I don't know if that's an option for us, but it's one thing we could look into. |
e.g. `ActiveRecord::Migration[5.1]` Fixes #949 Following the example of the devise gem, use erb. In addition, add the `.erb` file extension to fix syntax highlighting in editor. Deletes create_versions_spec.rb because the file is no longer valid ruby so those tests will have to be re-written. We can either generate a valid ruby file and continue to use similar assertions, or we can convert those features to use erb, which will have the benefit of cleaner generated files.
Closed by #950. Will release in 7.0.1. Thanks Travis. |
i was actually running 7.0.2. At least this is what my gemfile lock says:
|
e.g. `ActiveRecord::Migration[5.1]` Fixes paper-trail-gem#949 Following the example of the devise gem, use erb. In addition, add the `.erb` file extension to fix syntax highlighting in editor. Deletes create_versions_spec.rb because the file is no longer valid ruby so those tests will have to be re-written. We can either generate a valid ruby file and continue to use similar assertions, or we can convert those features to use erb, which will have the benefit of cleaner generated files.
In the Rails 5.1 rc1, the migrations created by PaperTrail 7.0.0 do not work and cause this error:
The migration has to be updated from
to something like:
It appears that this is still the case in the master branch of PaperTrail
The text was updated successfully, but these errors were encountered: