fix rails4 enums attribute issue #383
Conversation
|
Would you be open to make your test suite run against multiple versions of rails in a similar way than it is outlined in this article? http://www.rubytutorial.io/how-to-test-your-gem-against-multiple-rails/ |
|
We already do. Travis runs against Rails 3 and Rails 4. Was contemplating whether it was necessary to run against Rails 4.0 and 4.1, but I think that's likely overkill. We also test against multiple versions of Ruby. |
|
With the current setup is there a way to add a model with an AR enum field for the tests? I guess if I would use that model only from a test which exercises that feature it should break anything else. I will give that a spin when I got some time to see how it goes. |
With a Rails 4 enum field the changed attributes hash contains the mapped value and when prev[attr] assigns the value it will be lost.
|
I've added a test and rebased. |
|
My test fails on Travis with the rails3 gemfile. Any suggestion how to get around that? |
|
Cheers! I cleaned things up with d9cf951 if you're curious as to how I tackled the failures against |
|
@batter Thanks! Everyday is a schoolday :) |
I am not sure how to make a test for this. It should be AR 4 only test. As far as I see the current tests are run against 1 version of AR only.