Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some pseudo selectors #1537

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Feb 23, 2018

Adds some initial support for pseudo selectors, There are more that could be added but before I did that I started with the few I miss the most in order to get some feedback

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@@ -138,13 +138,38 @@ function matchAttributeSelector(node, token) {
}
}


function matchPseudoSelector(node, token, root) {
// console.log(token)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Collaborator

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I love how easy it was to implement these 😍

@ljharb ljharb merged commit b21ff0d into enzymejs:master Jun 26, 2018
@ljharb
Copy link
Member

ljharb commented Jun 26, 2018

(linking back to #703)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants