You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the React/JSX Styleguide 'Methods' section it says you shouldn't use _ to prefix internal methods. However, some of my code contains this convention and it isn't being caught by the linter. I double-checked the eslint rules for react/jsx files and there doesn't seem to be a rule defined for this convention.
Is this intentional? If so, why specify the rule in your documentation? I found a related issue (#490), but it wasn't clearly stated whether or not this rule should definitely be adhered to but rather that it's more or less up to the programmer.
Any clarification would be greatly appreciated.
The text was updated successfully, but these errors were encountered:
Our style guide does have many rules and recommendations that aren't enforced by linting rules. Sometimes this is an oversight, but sometimes the linter rule doesn't exist for it. I'm not sure off the top of my head which it is.
However, the guide should be discouraging _-prefixed methods in all cases, and if possible, we should locate or create a linter rule to enforce that.
In the React/JSX Styleguide 'Methods' section it says you shouldn't use
_
to prefix internal methods. However, some of my code contains this convention and it isn't being caught by the linter. I double-checked the eslint rules for react/jsx files and there doesn't seem to be a rule defined for this convention.Is this intentional? If so, why specify the rule in your documentation? I found a related issue (#490), but it wasn't clearly stated whether or not this rule should definitely be adhered to but rather that it's more or less up to the programmer.
Any clarification would be greatly appreciated.
The text was updated successfully, but these errors were encountered: