Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest 20 incompatability #6

Closed
gdborton opened this issue May 11, 2017 · 3 comments
Closed

Jest 20 incompatability #6

gdborton opened this issue May 11, 2017 · 3 comments

Comments

@gdborton
Copy link
Contributor

Jest 20 was released a few days ago, and it has corrected the issue around afterEach/afterAll so that they run in the correct order by default (we're currently reversing for correctness in 18/19).

We can unreverse, which will un-break jest 20, but will break 18/19 OR we can drop support for 18/19 and cut a new major release.... do you have a preference?
@gdborton
Copy link
Contributor Author

Alternatively we could use a package to dive into jest and find out what version it is, but I think that's icky.

@ljharb
Copy link
Collaborator

ljharb commented May 11, 2017

Is there any chance there's something reflectable about jest where we can differentiate this ordering? Can you link to the PR/commit that fixed this issue in jest?

@gdborton
Copy link
Contributor Author

Sure - jestjs/jest#3275
Also, it's in the change log for 20 - https://github.com/facebook/jest/blob/master/CHANGELOG.md

Fixed lifecycle hooks to make afterAll hooks operate the same as afterEach. (#3275)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @gdborton