-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through modifiers propType #1231
Conversation
d144670
to
28b0a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb this doesn't actually fully address the issue, but rather is designed to help us catch it earlier?
I slightly prefer a separate file.
@majapw yes, exactly right. Separate file it is! |
28b0a2c
to
e930dec
Compare
k updated, PTAL - i also made the propType stricter. |
a889cf5
to
8f1ac91
Compare
8f1ac91
to
3eb2170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
god custom prop definitions are always barely readable. Thank goodness for the display name. :)
This is related to #1198.
An alternative approach (which I'm happy to change to) would put the
modifiers
Set shape in a separate tiny file, and import it where needed.