Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for bug ticket #1575. #1577

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Pull Request for bug ticket #1575. #1577

merged 1 commit into from
Sep 13, 2019

Conversation

WarrickPardoe
Copy link
Contributor

Pull Request for bug ticket #1575.

@coveralls
Copy link

coveralls commented Mar 11, 2019

Coverage Status

Coverage increased (+0.05%) to 85.005% when pulling c588a9d on WarrickPardoe:master into 2657568 on airbnb:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some tests?

@WarrickPardoe
Copy link
Contributor Author

Sure, will look to get it done this weekend

@WarrickPardoe
Copy link
Contributor Author

WarrickPardoe commented Mar 18, 2019

I've updated the moment import to use the import with all the locales. I was having trouble trying to add the reset in the beforeEach callback, for some reason it was not resetting the locale correctly.

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Sep 10, 2019
@noratarano noratarano merged commit c588a9d into react-dates:master Sep 13, 2019
@ahuth ahuth mentioned this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants