Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocked navigation (min/maxDate) stories #1598

Conversation

ianduvall
Copy link
Contributor

This fixes two stories around blocked navigation with min and max dates. This change keeps today always between the min and max dates which makes the expected behavior of the story easier to understand.

@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage remained the same at 84.494% when pulling ee0b11e on ianduvall:update-blocked-navigation-stories into 5f1964b on airbnb:master.

Copy link
Contributor

@pedroabreu pedroabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@ianduvall
Copy link
Contributor Author

@ljharb @majapw thoughts?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@lencioni
Copy link
Contributor

Merged in 3b284c9

@lencioni lencioni closed this Jun 26, 2019
@ianduvall ianduvall deleted the update-blocked-navigation-stories branch April 21, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants