Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: wrong props to SDP onClose(#1674) #1678

Closed
wants to merge 4 commits into from
Closed

fixed: wrong props to SDP onClose(#1674) #1678

wants to merge 4 commits into from

Conversation

AlokTakshak
Copy link
Contributor

@AlokTakshak AlokTakshak commented Jun 8, 2019 •
edited by ljharb
Loading

Fixes #1674.

@AlokTakshak AlokTakshak mentioned this pull request Jun 8, 2019
Open
ljharb
ljharb requested changes Jun 8, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add some tests for this change.

src/components/SingleDatePicker.jsx Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 8, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 84.14% when pulling 78728b2 on AlokTakshak:issue-1674 into 11de201 on airbnb:master.

@lencioni
Copy link
Contributor

Merged in 3290bb4

@lencioni lencioni closed this Jun 26, 2019
@ndbroadbent ndbroadbent mentioned this pull request Nov 24, 2019
Closed
@ebwittenberg ebwittenberg mentioned this pull request Jan 31, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SingleDatePicker: startDate and endDate passed to onClose when clicking outside
4 participants
@AlokTakshak @coveralls @lencioni @ljharb