Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minDate and maxDate props to DateRangePicker #1793

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Add minDate and maxDate props to DateRangePicker #1793

merged 1 commit into from
Sep 19, 2019

Conversation

v47
Copy link
Contributor

@v47 v47 commented Sep 19, 2019

Currently, DateRangePicker does not support minDate and maxDate props. This PR will propagate them down to DayPickerRangeController.

@alanhamlett alanhamlett merged commit 47e0035 into react-dates:master Sep 19, 2019
@v47 v47 deleted the DateRangePicker-minDate-maxDate-props branch September 19, 2019 01:49
@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Sep 19, 2019
@ljharb
Copy link
Member

ljharb commented Sep 19, 2019

This should have had tests - not just stories - prior to merging. @v47 would you mind adding some in a followup PR?

@noratarano
Copy link
Contributor

cc @alanhamlett 🙏

@v47
Copy link
Contributor Author

v47 commented Sep 19, 2019

@ljharb I will be glad to add them.

@v47 v47 mentioned this pull request Sep 19, 2019
Merged
@pedroabreu pedroabreu mentioned this pull request Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhamlett alanhamlett alanhamlett approved these changes

Assignees
No one assigned
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v47 @ljharb @noratarano @alanhamlett