-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom month navigation buttons #1859
Conversation
caseklim
commented
Nov 13, 2019
45194a1
to
733ba64
Compare
@@ -469,8 +473,10 @@ class DateRangePicker extends React.PureComponent { | |||
|
|||
const withAnyPortal = withPortal || withFullScreenPortal; | |||
|
|||
/* eslint-disable jsx-a11y/no-static-element-interactions */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not doable in the same inline comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh TIL https://stackoverflow.com/a/56714489
733ba64
to
a75682b
Compare
src/components/DateRangePicker.jsx
Outdated
@@ -469,8 +473,9 @@ class DateRangePicker extends React.PureComponent { | |||
|
|||
const withAnyPortal = withPortal || withFullScreenPortal; | |||
|
|||
/* eslint-disable jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move it down to where it originally was and use eslint-disable-line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👌 I was trying to stay within the character limit but the line length is too long either way lol
a75682b
to
de15781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
de15781
to
35effaa
Compare