Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for applying default navigation button styling #1898

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

nkinser
Copy link
Contributor

@nkinser nkinser commented Jan 14, 2020

Don't set isDefaultNavPrev or isDefaultNavNext to true if custom navigation buttons are provided.

Before

image

After

image

@nkinser nkinser changed the title Fix logic for apply default navigation button styling Fix logic for applying default navigation button styling Jan 14, 2020
@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 14, 2020
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of a regression test?

@nkinser nkinser force-pushed the nk--fix-nav-default-styles branch 2 times, most recently from 1dc1611 to 159e444 Compare January 14, 2020 20:28
@nkinser nkinser force-pushed the nk--fix-nav-default-styles branch 7 times, most recently from 4e844e9 to 05635fb Compare January 15, 2020 00:18
@nkinser nkinser merged commit 5a24a0b into react-dates:master Jan 15, 2020
@nkinser nkinser deleted the nk--fix-nav-default-styles branch January 15, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants