Fixes bug where dates were automatically iso over anything else due to a prop error #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Feb 1, 2017
majapw
force-pushed
the
maja-fix-display-format-bug
branch
from
9ba4919
to
3d8ea0b
Compare
majapw
added
the
semver-patch: fixes/refactors/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #229, I apparently did not check the SDP (or if I did, my eyes glazes over when I saw an ISO format date in the input and called it a day). Either way, @vklein pointed out that this was likely due to an error in prop naming in #281.
SO. This fixes that issue. :)
to: @airbnb/webinfra @vklein