Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing keepOpenOnDateSelect prop #620

Merged
merged 2 commits into from
Jul 7, 2017
Merged

Added missing keepOpenOnDateSelect prop #620

merged 2 commits into from
Jul 7, 2017

Conversation

erin-doyle
Copy link
Collaborator

The DayPickerSingleDateController is using keepOpenOnDateSelect but that's not currently being passed to it from SingleDatePicker so it is instead always the default value of false.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.266% when pulling f41548f on erin-doyle:missing_keepOpenOnDateSelect_prop into d091b08 on airbnb:master.

majapw
majapw previously approved these changes Jul 6, 2017
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you for this fix. :)

I'll merge it in once the lint error is fixed. :)

@erin-doyle
Copy link
Collaborator Author

Oh wow, not sure how I missed all of those! 😳 Fixed!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.266% when pulling 164eca8 on erin-doyle:missing_keepOpenOnDateSelect_prop into d091b08 on airbnb:master.

@majapw majapw merged commit a05a63f into react-dates:master Jul 7, 2017
@erin-doyle erin-doyle deleted the missing_keepOpenOnDateSelect_prop branch July 7, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants