Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set explicit border radius on shortcuts button #792

Merged
merged 2 commits into from
Oct 27, 2017
Merged

set explicit border radius on shortcuts button #792

merged 2 commits into from
Oct 27, 2017

Conversation

ingiulio
Copy link
Contributor

Addresses #737

I was seeing this happening in Chrome 62 on a macbook.
Digging into Chrome's changelog, looks like there is now a default border-radius set for elements on OS X:

https://www.chromestatus.com/features/5743649186906112

That has a link to this:

The summary of changes:

Before these CLs, the default style for buttons was:
  background-color: ButtonFace; (-> #C0C0C0)
  boder: 2px outset ButtonFace;
  padding: 2px 6px 3px 6px;

After these CLs, it is:
  background-color: ButtonFace; (-> #FFFFFF)
  border-color: #D8D8D8 #D1D1D1 #BABABA;
  border-radius: 4px;
  border-style: solid;
  border-width: 1px;
  padding: 1px 7px 2px 7px;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.662% when pulling 10c479b on ingiulio:shortcuts_button_border_radius into a865f5b on airbnb:master.

ljharb
ljharb approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Oct 24, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.76% when pulling 71904f4 on ingiulio:shortcuts_button_border_radius into b832da5 on airbnb:master.

@majapw
Copy link
Collaborator

majapw commented Oct 27, 2017

LGTM!

@majapw majapw merged commit 371e074 into react-dates:master Oct 27, 2017
ljharb pushed a commit that referenced this pull request Oct 31, 2017
@majapw @ljharb
Merge pull request #792 from ingiulio/shortcuts_button_border_radius
f645091 
set explicit border radius on shortcuts button
 Conflicts:
	src/components/DayPickerKeyboardShortcuts.jsx

Adapted from #792
@ljharb
Copy link
Member

ljharb commented Oct 31, 2017

Also released in v12.7.1.

@majapw
Copy link
Collaborator

majapw commented Oct 31, 2017

Thanks @ljharb! You are a hero

@ingiulio ingiulio deleted the shortcuts_button_border_radius branch October 31, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingiulio @coveralls @majapw @ljharb