Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back today modifier #861

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Adds back today modifier #861

merged 1 commit into from
Nov 28, 2017

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Nov 28, 2017

Quick patch for #859

to: @erin-doyle @uvtzxpm @ljharb

@majapw majapw added the semver-minor: new stuff Any feature or API addition. label Nov 28, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.571% when pulling 0ce7164 on maja-add-back-today-modifier into b2a4874 on master.

@erin-doyle
Copy link
Collaborator

Perhaps some tests on these classes getting added when expected would be nice.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any regression test?

@majapw
Copy link
Collaborator Author

majapw commented Nov 28, 2017

It's a bit difficult to write a test for this right now because it is a styling detail (and there's only one theme registered for the examples so if we have styling on today for one example, we have them for all. I'll think about this some more, but I think I'm gonna merge this in as is.

@majapw majapw merged commit 6b22db8 into master Nov 28, 2017
@majapw majapw deleted the maja-add-back-today-modifier branch November 28, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants