Use theme font size in a meaningful way #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
majapw
force-pushed
the
maja-force-font-size-to-read-from-theme
branch
from
26d0d80
to
e2f494c
Compare
ljharb
approved these changes
Dec 6, 2017
| > | ||
| <div | ||
| {...css(styles.DayPickerKeyboardShortcuts_title)} | ||
| id="DayPickerKeyboardShortcuts__title" |
There was a problem hiding this comment.
why change the BEM __ to a single _?
There was a problem hiding this comment.
This is the pattern I've been using throughout and this was a place I'd missed it. If you look at the rest of the app, I've been using __ for modifiers and _ for elements. The title, in this case, is an element, not a modifier.
|
@ljharb I would argue that this is a patch because inherited styles from anything other than 14px look super weird (and kind of broken) without this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set the font size in the theme and then did nothing about it. This worked in the storybook and anywhere else where the page font size was 14px, but if you changed that value, everything in the calendar would inherit from it which could be weird. This fixes the font size to a default value of 14px. If you want something different, you should register a theme value of
inherit, or override appropriately.to: @ljharb @erin-doyle @airbnb/webinfra