-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dayAriaLabelFormat into DatePickerRange and SingleDatePicker #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good after we add defaultProp values for the dayAriaLabelFormat prop on the SDP and DRP. Thanks for doing this!
@@ -335,6 +335,7 @@ class DateRangePicker extends React.Component { | |||
customCloseIcon, | |||
onClose, | |||
phrases, | |||
dayAriaLabelFormat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a defaultProp value for this one
@@ -364,6 +364,7 @@ class SingleDatePicker extends React.Component { | |||
firstDayOfWeek, | |||
customCloseIcon, | |||
phrases, | |||
dayAriaLabelFormat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a defaultProp value for this one
db7c40e
to
12d6579
Compare
@majapw Should I add defaultProp for |
@koba04 it would be good to be explicit, so in the case of CalendarMonth, CalendarMonthGrid, DayPicker, DayPickerRangeController and DayPickerSingleDateController... we don't need a defaultProp value of |
12d6579
to
c7c16b7
Compare
@majapw That makes sense. I've fixed it. Thank you!
I'll fix it as another PR. |
CI was failed due to #995 |
c7c16b7
to
4cad8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koba04 thanks for adding this!
4cad8dc
to
ef7f1e4
Compare
ef7f1e4
to
b97db46
Compare
Thanks! |
This PR is a follow-up for #857 (comment)
I've add
dayAriaLabelFormat
intoDatePickerRange
andSingleDatePicker
and have mentioned in README.