Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An in-range update of react-native is breaking the build 🚨 #4

Open
greenkeeper bot opened this issue Feb 3, 2017 · 11 comments
Open

An in-range update of react-native is breaking the build 🚨 #4

greenkeeper bot opened this issue Feb 3, 2017 · 11 comments
Assignees
@lencioni
Labels
greenkeeper

Comments

@greenkeeper
Copy link

greenkeeper bot commented Feb 3, 2017

Version 0.41.1 of react-native just got published.

Branch Build failing 🚨
Dependency react-native
Current Version 0.41.0
Type peerDependency

This version is covered by your current version range and after updating it in your project the build failed.

As react-native is “only” a peerDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴
@greenkeeper
Copy link
Author

greenkeeper bot commented Feb 6, 2017

Version 0.41.2 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented Mar 17, 2017

Version 0.42.2 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Release Notes February 2017

This is February 2017 release, also known as 0.42.0.

Breaking changes

Android: windowSoftInputMode for new apps

e3d4ace - @mkonicek

All new apps created with react-native init are going to have windowSoftInputMode:``adjustResize instead of adjustUnspecified, which is default. That change makes keyboard handling on Android automatic and doesn't require any Javascript solutions, like KeyboardAvoidingView to be used. You can see the rationale behind that change along the screenshots here. It shouldn't be breaking for most of the users.

Android: (Re)move JSBundleLoader.getSourceUrl()

89d72c9 - @amnn

If you are using any of the following API's to access the Source URL of the bundle:

  • JSBundleLoader.getSourceUrl()
  • ReactInstanceManager.getSourceUrl()
  • ReactInstanceManager.getJSBundleFile()

you have to now refer to the source of truth for this information, which is at CatalystInstance.getSourceURL(), or the return value of JSBundleLoader.loadScript().

Android: Remove RecyclerViewBackedScrollView

6ec5654 - @mkonicek

RecyclerViewBackedScrollView was added a long time ago to work around the scroll-back-when-data-is-added bug, but that has now been fixed directly in the ScrollView (ReactScrollView.java) in open source and internally.

Both: Improve validation of transform property

0ed31eb - @janicduplessis

This commit improves validations of the transform object that are done on the Javascript side and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native the validations got out of sync a bit. In this change we make sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms.

General

Bugfixes

New features and enahcements

Android

Bugfixes

New features and enahcements

iOS

Bugfixes

New features and enhancements

General

Bugfixes

New features and enhancements

@greenkeeper
Copy link
Author

greenkeeper bot commented Mar 18, 2017

Version 0.42.3 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

@greenkeeper
Copy link
Author

greenkeeper bot commented Apr 3, 2017

Version 0.43.0 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented Apr 5, 2017

Version 0.43.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Release Notes March 2017

Breaking changes

Correct value of Dimensions.get('screen').fontScale

(186f308) - @rigdern

On Android, the following properties now return a different number:

  • Dimensions.get('window').fontScale
  • Dimensions.get('screen').fontScale
  • PixelRatio.getFontScale()

This is a breaking change to anyone who was using these properties because the meaning of these properties has now changed.

These properties used to return a value representing font scale times density (DisplayMetrics.scaledDensity). Now they return a value representing just font scale (Configuration.fontScale).

Only call batchDidComplete when there were actually native calls dispatched

(5f09ca4) - @astreet

This is breaking because it affects the contract for onBatchComplete, but modules really shouldn't (and probably aren't) depending on it being called without any actual native module method calls having happened.

Android

Bugfixes

New features and enhancements

iOS

Bugfixes

New features and enhancements

General

Bugfixes

New features and enhacements

@greenkeeper
Copy link
Author

greenkeeper bot commented Apr 6, 2017

Version 0.43.2 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented Apr 20, 2017

Version 0.43.4 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented May 1, 2017

Version 0.44.0 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented May 26, 2017

Version 0.44.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented May 29, 2017

Version 0.44.2 just got published.

Your tests are still failing with this version. Compare the changes 🚨

@greenkeeper
Copy link
Author

greenkeeper bot commented Jun 6, 2017

Version 0.44.3 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Release Notes April 2017

General

Breaking change

Remove support for @provides

6cbb57d - @jetzhliu

If you were using @provides NameOfModule, you should now switch to @providesModule

Only call batchDidComplete when there were actually native calls dispatched

c8d922b - @facebook/team-jest

This is breaking because it affects the contract for onBatchComplete, but modules really shouldn't (and probably aren't) depending on it being called without any actual native module method calls having happened.

Navigator has been deprecated

92d985f - @ericvicenti

Navigator has been deprecated in favor of React Navigation. If you wish to continue using Navigator, you can install the react-native-custom-components package which provides the legacy Navigator component. Find out more at https://github.com/facebookarchive/react-native-custom-components

Bugfixes

New features and enhancements

Yoga

iOS

Breaking changes

Remove MapViewIOS

48f30ec - @mkonicek

<MapView /> was deprecated for a while, in this release it is removed from react-native.

Bugfixes

New features and enhancements

Android

Bugfixes

  • Fix java.lang.RuntimeException: Tried to get non-existent cookie (d2939ea)
  • Apply numeric text event bubbling fix (17cb70e) - @sebmarkbage
  • CLI: Update run-android to work on Windows (f891985) - @jrodiger
  • Don't crash in StackTraceHelper.convertJsStackTrace (957b55c) - @petterh
  • Fix crash if native code tries to update the size of a modal view after JS has removed it (5873a22) - @astreet
  • Fix FrescoModule not initialised in Nodes (63fa621)
  • Fix NullPointerException in ReactShadowNode.toString() (242a58f) - @petterh
  • Fix ClassCastException in ReactModuleSpecProcessor (379b60d)
  • Fix order of width and height in Fresco (c311096)

New features and enhancements

  • PickerAndroid: Convert children to an array before accessing with a position (720e195) - @justim
  • Allow DeviceInfoModule to be instantiated with only an android Context (ec4b854) - @mhorowitz
  • Explain how to package app for or Nexus/Maven deployment (a0b5a6e) - @MattFoley
  • Profiler: Remove the old heap profiler visualization code (af590b0) - @cwdick
  • Profiler: Download files through RN packager connection (373eb61) - @cwdick
  • Warn when long timers are set with AlarmManager (3637bce) - @astreet
  • Extract PackagerConnectionSettings to ensure easier reusability of PackagerConnection module (60142ad)
  • Ensure ResourceDrawableIdHelper is thread-safe (11814a5) - @ashwinb
  • Don't call clearFrameCallback() if we don't have a ReactChoreographer to clear the frame callback on (ba75d99) - @AaaChiuuu
  • Update PositionError to be an object as per docs (94d93f7) - @dabit1
  • Optimize ReactShadowNode by more manually converting between string and enums (436a9a5) - @emilsjolander
  • Set hasNewLayout on children when changing their layout due to display none parent (4bf2d8c) - @emilsjolander
  • Replace string comparison with enum (63035a4) - @BruinBear
  • Make bridge load module lazy (f804af2)
  • Make SystraceRequestListener extend BaseRequestListener (01a0e10) - @kirwan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lencioni lencioni

Labels
greenkeeper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lencioni