Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monolog 3 support #117

Open
gbirke opened this issue Jul 28, 2022 · 2 comments · May be fixed by #127
Open

Monolog 3 support #117

gbirke opened this issue Jul 28, 2022 · 2 comments · May be fixed by #127

Comments

@gbirke
Copy link
Contributor

gbirke commented Jul 28, 2022

Monolog 3 has changed the signature of the AbstractProcessingHandler::write method from an array to a record object, leading to type errors and static analysis errors.

If you want to stay backwards-compatible, you could avoid typing write method and accept both arrays or records. Monolog\LogRecord implements the ArrayAccess interface, so the method body can stay the same
@gbirke gbirke mentioned this issue Jul 28, 2022
Closed
@StuartCreed
Copy link

Hi there all. Thanks for this package, much appreciated. I was wondering whether there was there any update regarding an upgrade to Monolog 3? Laravel 10 now ships with Monolog 3. Also is this repo still maintained? There doesn't seem to have been an update for a while.

Sperling-0 added a commit to wmde/phpbrake that referenced this issue Jan 25, 2024
@Sperling-0
Update Monolog to version 3
b85b4b8 
This fixes airbrake#117
@Sperling-0 Sperling-0 linked a pull request Jan 25, 2024 that will close this issue
Open
@lindyhopchris
Copy link

Would be great to get this, especially as there is an open PR that looks like it does the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Monolog to version 3 wmde/phpbrake
3 participants
@gbirke @lindyhopchris @StuartCreed