From 3b1864f288b5a7a2834ff36ab9d47c77188dadd4 Mon Sep 17 00:00:00 2001 From: "Krishna (kc) Glick" Date: Mon, 23 Jan 2023 16:06:12 -0500 Subject: [PATCH] Checkboxes in dropdowns now correctly visually update when clicked (#21725) * preventDefault was necessary to make the checkboxes work * e -> event to reduce file diff --- airbyte-webapp/src/components/ui/DropDown/components/Option.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/airbyte-webapp/src/components/ui/DropDown/components/Option.tsx b/airbyte-webapp/src/components/ui/DropDown/components/Option.tsx index 49fcd9c81299..41ee0a538c74 100644 --- a/airbyte-webapp/src/components/ui/DropDown/components/Option.tsx +++ b/airbyte-webapp/src/components/ui/DropDown/components/Option.tsx @@ -65,6 +65,8 @@ export const DropDownOption: React.FC = (props) => { // for cases where the Dropdown is a child of a clickable parent such as a table row. props.selectOption(props.data); event.stopPropagation(); + // The checkbox does not work properly without this + event.preventDefault(); }} >