From 5d00e5b47698fb3766c13d88f12bbf91f14edbc7 Mon Sep 17 00:00:00 2001 From: Marius Posta Date: Wed, 21 Feb 2024 06:11:02 -0800 Subject: [PATCH] .github: remove connector checklist (#35484) --- .github/workflows/connector_checklist.yml | 23 -------------- .../workflows/connector_checklist_require.yml | 31 ------------------- .../connectors/CONNECTOR_CHECKLIST.yaml | 11 ------- 3 files changed, 65 deletions(-) delete mode 100644 .github/workflows/connector_checklist.yml delete mode 100644 .github/workflows/connector_checklist_require.yml delete mode 100644 airbyte-ci/connectors/CONNECTOR_CHECKLIST.yaml diff --git a/.github/workflows/connector_checklist.yml b/.github/workflows/connector_checklist.yml deleted file mode 100644 index 127ac5ae521d..000000000000 --- a/.github/workflows/connector_checklist.yml +++ /dev/null @@ -1,23 +0,0 @@ -name: Add Connector Merge Checklist -on: - pull_request_target: - types: [opened, reopened] - paths: - - "airbyte-integrations/connectors/source-**" - - "airbyte-integrations/connectors/destination-**" - - "airbyte-integrations/connectors/third-party/**" -jobs: - checklist_job: - name: Add Connector Merge Checklist Job - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v3 - - name: Checklist - uses: wyozi/contextual-qa-checklist-action@master - with: - comment-header: "### Before Merging a Connector Pull Request \n\n Wow! What a great pull request you have here! 🎉 \n\n To merge this PR, ensure the following has been done/considered for each connector added or updated: \n\n" - comment-footer: "If the checklist is complete, but the CI check is failing, \n\n1. Check for hidden checklists in your PR description \n\n2. Toggle the github label `checklist-action-run` on/off to re-run the checklist CI." - show-paths: false - input-file: airbyte-ci/connectors/CONNECTOR_CHECKLIST.yaml - gh-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/connector_checklist_require.yml b/.github/workflows/connector_checklist_require.yml deleted file mode 100644 index 073cc69842c7..000000000000 --- a/.github/workflows/connector_checklist_require.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: Require Connector Checklist -on: - pull_request: - types: - [ - opened, - edited, - synchronize, - labeled, - unlabeled, - reopened, - ready_for_review, - ] - paths: - - "airbyte-integrations/connectors/source-**" - - "airbyte-integrations/connectors/destination-**" - - "airbyte-integrations/connectors/third-party/**" -jobs: - check_for_required: - name: Require Connector Merge Checklist Job - runs-on: ubuntu-latest - steps: - - name: Ensure All Checklist Checked - uses: mheap/require-checklist-action@v2 - with: - requireChecklist: false # TODO (ben) reenable in one week once pull request templates have been updated - - name: Send Error Message - if: failure() - run: | - echo "::error::All checklist items not checked. Review your PR description and comments for unchecked items." - exit 1 diff --git a/airbyte-ci/connectors/CONNECTOR_CHECKLIST.yaml b/airbyte-ci/connectors/CONNECTOR_CHECKLIST.yaml deleted file mode 100644 index 7957973df4e7..000000000000 --- a/airbyte-ci/connectors/CONNECTOR_CHECKLIST.yaml +++ /dev/null @@ -1,11 +0,0 @@ -paths: - "airbyte-integrations/connectors/**": - - PR name follows [PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention) - - "[Breaking changes are considered](https://docs.airbyte.com/contributing-to-airbyte/change-cdk-connector/#breaking-changes-to-connectors). If a **Breaking Change** is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan." - - Connector version has been incremented in the Dockerfile and metadata.yaml according to our [Semantic Versioning for Connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors) guidelines - - You've updated the connector's `metadata.yaml` file any other relevant changes, including a `breakingChanges` entry for major version bumps. See [metadata.yaml docs](https://docs.airbyte.com/connector-development/connector-metadata-file/) - - Secrets in the connector's spec are annotated with `airbyte_secret` - - All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...) - - Changelog updated in `docs/integrations//.md` with an entry for the new version. See changelog [example](https://docs.airbyte.io/integrations/sources/stripe#changelog) - - Migration guide updated in `docs/integrations//-migrations.md` with an entry for the new version, if the version is a breaking change. See migration guide [example](https://docs.airbyte.io/integrations/sources/faker-migrations) - - If set, you've ensured the icon is present in the `platform-internal` repo. ([Docs](https://docs.airbyte.com/connector-development/connector-metadata-file/#the-icon-field))